Implement custom OVMF firmware #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olethanh
force-pushed
the
andres-feature-implement_custom_ovmf
branch
from
24b83ab to
5dd3fd4
Compare
olethanh
approved these changes
Jun 25, 2024
|
I made a few fix after testing, waiting to see if the CI pass now |
|
Had to make some more modification to make the volumes working |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-confidential #646 +/- ##
====================================================
+ Coverage 59.13% 60.23% +1.10%
====================================================
Files 65 67 +2
Lines 5778 5787 +9
Branches 627 618 -9
====================================================
+ Hits 3417 3486 +69
+ Misses 2215 2151 -64
- Partials 146 150 +4 ☔ View full report in Codecov by Sentry. |
…ey instances. Solution: Use new aleph-message version that includes that data schema and implement it on the qemu confidential resources.
olethanh
force-pushed
the
andres-feature-implement_custom_ovmf
branch
from
f4653a4 to
9f2b601
Compare
olethanh
force-pushed
the
andres-feature-implement_custom_ovmf
branch
from
9f2b601 to
544ffce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: A user cannot specify which OVMF firmware want to use for the confidential instances.
Solution: Use new
aleph-messageversion that includes that data schema and implement it on the qemu confidential resources.It also implements the extra volume use for qemu instances.